Forward-port assorted participant-side checks & check keys for structural equality 3.x #19691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylant-da
force-pushed
the
upgrade-checks-disallow-key-upgrades-3.x
branch
2 times, most recently
from
b5bbf92
to
9d9e2e9
Compare
* Upgrades validation for every package in dar * fix 1.15 error * transitivity is fine * remove unnecessary parens/braces as pointed out by IJ + use EitherUtil.IfThenET for consistency * add tests for dependency upgrade validation * put back message when skipping validation * address comments * comment to address Tudor's comment --------- Co-authored-by: Samuel Williams <[email protected]>
Fixes for interfaces Co-authored-by: Remy <[email protected]> --------- Co-authored-by: Remy <[email protected]>
…kages (#19357)" --------- Co-authored-by: Remy <[email protected]>
…pgrade checks (#19380)")
* Add utility package upgrade check * Add a test that uploading the std lib for 2 different LF versions shouldn't fail * Fix tests * Fix invalid package preferences --------- Co-authored-by: Paul Brauner <[email protected]>
* Fix key upgrade validation in 2.9 (#19509) Fix key upgrade validation in 2.9 * Fix key type upgrade check test to a weaker one for compiler-side checks --------- Co-authored-by: Dylan Thinnes <[email protected]>
dylant-da
force-pushed
the
upgrade-checks-disallow-key-upgrades-3.x
branch
from
9d9e2e9
to
40e24aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports many commits, and brings changes from #19666
TODO: Disable daml-prim/daml-stdlib check, figure out why that's still needed to make tests pass